Add option to configure ForceAuthn per request#592
Closed
nflaig wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
cc @tngan |
Contributor
Author
|
this has been added in #618 now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option to configure
ForceAuthnper request, set to false by default.The current implementation passes options as 3rd param and adds
customTagReplacementto it while keeping it backward compatible by allowingcustomTagReplacementto be passed as a function directly. The workaround could be removed in the next major release.After this PR is merged would allow to easily address #163 as well.
Closes #359